Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Biome linting with auto-fixes [DT-7060] #53

Merged
merged 25 commits into from
Feb 10, 2025
Merged

chore: Biome linting with auto-fixes [DT-7060] #53

merged 25 commits into from
Feb 10, 2025

Conversation

lanesawyer
Copy link
Collaborator

What

  • Runs auto fixes for Biome linting rules
  • Turns on lint command in CI (but we won't have it blocking merges, since there are still about 49 errors to resolve)

How

  • pnpm lint:fix
  • Add the lint command to the placeholder linting CI job we had

PR Checklist

  • Is your PR title following our conventional commit naming recommendations?
  • Have you filled in the PR Description Template?
  • Is your branch up to date with the latest in main?
  • Do the CI checks pass successfully?
  • Have you smoke tested the example applications?
  • Did you check that the changes meet accessibility standards?
  • Have you tested the application on these browsers?
    • Chrome (Fully supported)
    • Firefox (Major bug fixes supported)
    • Safari (Major bug fixes supported)

@lanesawyer
chore: Install biome
f9d9902
@lanesawyer
Add fmt command
29cf1f3
@lanesawyer
Add lint command
4881c4e
@lanesawyer
Tweak config to not run on generated files
eebd3dc
@lanesawyer
Add check command to check lint and format
693c40a
@lanesawyer
Add check:fix command
035a169
@lanesawyer
Documentation on linter and formatter
d5f045f
@lanesawyer
Merge branch 'main' into lane/biome
56335f2
@lanesawyer
Merge branch 'main' into lane/biome
3c664c5
@lanesawyer
Change ignored files directory after Parcel merge
66adb1b
@lanesawyer
Biome at root level to enable VS Code plugin, extends base config
a86ed47
@lanesawyer
Merge branch 'main' into lane/biome
d99631e
@lanesawyer
Add biome commands to package.json
1021c1d
@lanesawyer
Remove prettier
bf27ef2
@lanesawyer
Merge branch 'main' into lane/biome
251cf93
@lanesawyer
Apply biome fixes
9e176c5
@lanesawyer
Fixing errors in examples
6d5d16c
@lanesawyer
Tweak command based on API change warning
e9415c2
@lanesawyer
Get ready to merge in main
ef4ed85
@lanesawyer
Merge branch 'main' into lane/biome
6d6513b
@lanesawyer
Auto fix, also ignore dist folders
3fee4f6
@lanesawyer
Run lint command on CI
980d406
@lanesawyer lanesawyer requested a review from a team as a code owner February 10, 2025 20:37
@lanesawyer
Copy link
Collaborator Author

@crispipear @Jarbuckle I ran autofixes for these. Biome has "unsafe auto-fixes" and I did not run those. So theoretically, all these changes are good to go, since they only apply the ones that are universally safe.

Jarbuckle
Jarbuckle approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@Jarbuckle Jarbuckle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OME-Zarr and DZI examples are working as expected; approved!

@lanesawyer lanesawyer merged commit fdecfa9 into main Feb 10, 2025
4 of 5 checks passed
@lanesawyer lanesawyer deleted the lane/biome branch February 10, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jarbuckle Jarbuckle Jarbuckle approved these changes

@crispipear crispipear Awaiting requested review from crispipear crispipear is a code owner automatically assigned from AllenInstitute/app-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lanesawyer @Jarbuckle